test(server): retarget Firestore emulator image after GCR tag removal - #42182
Merged
Conversation
Google deleted gcr.io/google.com/cloudsdktool/cloud-sdk:316.0.0-emulators. Pin the published google-cloud-cli:582.0.0-emulators replacement.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
WalkthroughThe Firestore plugin test now uses the Google Cloud CLI emulator image version ChangesFirestore emulator testing
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
sondermanish
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google deleted the pinned Testcontainers image
gcr.io/google.com/cloudsdktool/cloud-sdk:316.0.0-emulators(404 / manifest unknown). That crashesFirestorePluginTestduring container start and fails a server unit-test shard on every PR.Pin the published replacement
gcr.io/google.com/cloudsdktool/google-cloud-cli:582.0.0-emulators. Testcontainers 1.20.1 already accepts this image name.Verified locally:
FirestorePluginTest— Tests run: 35, Failures: 0, Errors: 0.Fixes https://linear.app/appsmith/issue/APP-15872
Testing
Suggested Cypress tags or specs:
Test-only image pin; no runtime behavior change. Cypress skipped.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit