Skip to content

test(server): retarget Firestore emulator image after GCR tag removal - #42182

Merged
subrata71 merged 1 commit into
releasefrom
fix/app-15872
Sep 1, 2026
Merged

test(server): retarget Firestore emulator image after GCR tag removal#42182
subrata71 merged 1 commit into
releasefrom
fix/app-15872

Conversation

@subrata71

@subrata71 subrata71 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Google deleted the pinned Testcontainers image gcr.io/google.com/cloudsdktool/cloud-sdk:316.0.0-emulators (404 / manifest unknown). That crashes FirestorePluginTest during container start and fails a server unit-test shard on every PR.

Pin the published replacement gcr.io/google.com/cloudsdktool/google-cloud-cli:582.0.0-emulators. Testcontainers 1.20.1 already accepts this image name.

Verified locally: FirestorePluginTest — Tests run: 35, Failures: 0, Errors: 0.

Fixes https://linear.app/appsmith/issue/APP-15872

Testing

  • Client unit tests
  • Server unit tests
  • Cypress
  • Playwright
  • Deploy preview
  • Not applicable

Suggested Cypress tags or specs:

Test-only image pin; no runtime behavior change. Cypress skipped.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Tests
    • Updated the Firestore emulator test environment to use the current Google Cloud CLI image, improving test compatibility and reliability.

Google deleted gcr.io/google.com/cloudsdktool/cloud-sdk:316.0.0-emulators.
Pin the published google-cloud-cli:582.0.0-emulators replacement.
@linear-code

linear-code Bot commented Sep 1, 2026

Copy link
Copy Markdown

APP-15872

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 7ea6fe99-01a5-417a-bed8-304e8597bd84

📥 Commits

Reviewing files that changed from the base of the PR and between 75847cf and 61fff9d.

📒 Files selected for processing (1)
  • app/server/appsmith-plugins/firestorePlugin/src/test/java/com/external/plugins/FirestorePluginTest.java

Walkthrough

The Firestore plugin test now uses the Google Cloud CLI emulator image version 582.0.0 instead of the deprecated Cloud SDK emulator image.

Changes

Firestore emulator testing

Layer / File(s) Summary
Update emulator test image
app/server/appsmith-plugins/firestorePlugin/src/test/java/com/external/plugins/FirestorePluginTest.java
The Firestore emulator container now uses google-cloud-cli:582.0.0-emulators.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: amelia-c0n, sebastianiv21, sondermanish, tomjose92, wyattwalter

Poem

A cloud image takes flight
The emulator shines bright
Version five-eight-two
Keeps tests fresh and true
Firestore hums tonight

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/app-15872

Comment @coderabbitai help to get the list of available commands.

@subrata71
subrata71 marked this pull request as ready for review September 1, 2026 10:22
@subrata71
subrata71 requested a review from a team as a code owner September 1, 2026 10:22
@subrata71
subrata71 merged commit 418ff80 into release Sep 1, 2026
25 of 26 checks passed
@subrata71
subrata71 deleted the fix/app-15872 branch September 1, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants