Open
Conversation
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
1 similar comment
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
simu
force-pushed
the
feat/render-floating-ip-addresses
branch
from
a499334 to
c7fad32
Compare
simu
force-pushed
the
feat/render-floating-ip-addresses
branch
from
c7fad32 to
507b8e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extend the component's
LoadBalancerresource generation to support.spec._floatingIPAddresseswhich makes configuring floating IP addresses through the hierarchy easier.This is required for easy gradual configuration of optional IPv6 floating IPs, cf. appuio/component-openshift4-terraform#142
Note: This shouldn't break any current custom VSHN configurations.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.