Refactor user-data handling in node-group module#77
Draft
simu wants to merge 23 commits intofeat/cloudscale-no-puppetfrom
Draft
Refactor user-data handling in node-group module#77simu wants to merge 23 commits intofeat/cloudscale-no-puppetfrom
simu wants to merge 23 commits intofeat/cloudscale-no-puppetfrom
Conversation
Allowed CIDRs are provided in a map which uses the listening port as key and holds the list of allowed CIDRs as value. If a listening port isn't present in the map, `allowed_cidrs` for that port's listener is left empty which allows all traffic.
This allows us to make changes to the LBs that require the instance to be recreated without having to modify the cluster's DNS records. Additionally, we can set the PTR records on the floating IPs.
We move the user-data (ignition) definition into a local variable and keep it as structured data which we `jsonencode()` when specifying it as the `user_data` field for the compute instance.
simu
force-pushed
the
feat/refactor-user-data
branch
from
da13e68 to
d91839c
Compare
simu
force-pushed
the
feat/cloudscale-no-puppet
branch
from
efbddb2 to
5e22e6f
Compare
simu
force-pushed
the
feat/cloudscale-no-puppet
branch
from
be3c698 to
8085c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We move the user-data (ignition) definition into a local variable and keep it as structured data which we
jsonencode()when specifying it as theuser_datafield for the compute instance.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog