Support TLS for Postgres VSS stores#179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sslmode=requireis present?sslmode=requirefrom the CLIsslmode=requireon the non-TLS path for compatibilityValidation
cargo check -p vss-storecargo check -p network-nodecargo test -p vss-storepnpm --filter @aptos-labs/ace-cli typecheckgit diff --checkExisting deployment rollout
ALLOW_UNENCRYPTED_AND_ENCRYPTED. This is the current/default compatibility state and lets old no-SSL nodes keep running while new SSL-capable nodes roll out.sslmode=require. New CLI-generated deployments include it by default.ENCRYPTED_ONLY.Rollback before step 4 is just redeploying nodes with the old URL. Rollback after step 4 is setting Cloud SQL back to
ALLOW_UNENCRYPTED_AND_ENCRYPTED.This is encrypt-only TLS for now. It intentionally does not enforce certificate/hostname verification because current private-IP Cloud SQL URLs use IP addresses; verified TLS should be a separate follow-up with CA/hostname/proxy handling.