[rosetta] Audit fixes for currency config, construction, balances#20231
Open
gregnazario wants to merge 3 commits into
Open
[rosetta] Audit fixes for currency config, construction, balances#20231gregnazario wants to merge 3 commits into
gregnazario wants to merge 3 commits into
Conversation
Address correctness bugs found while auditing aptos-rosetta: - Accept FA-only currencies from the currency config file - Skip metadata simulation when both max gas and gas price are set - Require public keys unless both gas fields are provided - Validate block index/hash agreement - Avoid silent stake balance parse failures and fee mul overflow Co-authored-by: Greg Nazario <greg@gnazar.io>
gregnazario
commented
Jul 16, 2026
Keep unparsable stake balances as zero, restore ignore-hash-when-index block lookup with documentation, and note a TODO for simulation without public keys. Co-authored-by: Greg Nazario <greg@gnazar.io>
gregnazario
marked this pull request as ready for review
July 20, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a few correctness bugs in
crates/aptos-rosettafound during review:--currency-config-file(previously skipped whenmove_typewas absent)/construction/metadatasimulation when both max gas and gas price are providedchecked_mulfor suggested fee calculationTest plan
cargo test -p aptos-rosetta --lib