fix(table): restore text selection on read-only table rows - #1731
Open
WGB5445 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👷 Deploy Preview for aptos-explorer processing.
|
Bundle ReportChanges will decrease total bundle size by 6.16MB (-36.48%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: aptos-explorer-client-esmAssets Changed:
Files in
view changes for bundle: aptos-explorer-server-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
+ Coverage 42.87% 42.93% +0.05%
==========================================
Files 232 232
Lines 10800 10802 +2
Branches 4187 4189 +2
==========================================
+ Hits 4631 4638 +7
+ Misses 6147 6143 -4
+ Partials 22 21 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GeneralTableRow applied user-select: none to every row, which blocked drag-selecting values in desktop key/value tables such as Fee Statement event views. Only interactive rows suppress selection now. Co-authored-by: Cursor <cursoragent@cursor.com>
WGB5445
changed the title
WGB5445
force-pushed
the
cursor/event-card-copy-actions-7030
branch
from
September 2, 2026 06:12
8e9e9e8 to
0f06726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On desktop, formatted event tables in the transaction Events tab — notably
0x1::transaction_fee::FeeStatement, Decibel, and multisig views — did not allow drag-selecting numbers or partial values with the mouse. Narrow viewports were unaffected because they render stacked label/value blocks instead of a table.Root cause:
ResponsiveKeyValueRowrenders throughGeneralTableRowon wide viewports.GeneralTableRowapplieduser-select: noneto every row, even rows with notooronClick. That style is appropriate for clickable list rows (transactions, validators, etc.) where drag gestures should not highlight text, but it blocked normal text selection in read-only key/value tables.Fix:
GeneralTableRownow suppresses selection only when the row is interactive (tooronClick). Read-only rows inherit the browser default and values can be drag-selected and copied again.Scope
app/components/Table/GeneralTableRow.tsx— conditionaluser-selectapp/components/Table/GeneralTableRow.test.tsx— regression tests (read-only vs interactive rows)docs/FEATURES_SPECIFICATION.md— FEAT-UI-005 text-selection behavior + Appendix B test entryCHANGELOG.md—[Unreleased]fix entryTest plan
/txn/7039459602/eventson a desktop-width viewportpnpm fmt/pnpm lintpnpm test --run app/components/Table/GeneralTableRow.test.tsxChecklist
pnpm fmtpnpm lint(tsc --noEmit+ Biome)pnpm test --run(newGeneralTableRow.test.tsxcovers FEAT-UI-005 / FEAT-TXN-004)docs/FEATURES_SPECIFICATION.mdupdatedCHANGELOG.mdupdated under[Unreleased]llms*.txt/sitemap.xmlneed no updates