Skip to content

fix(dotnet): identify deps.json root project from dependency graph #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jetersen wants to merge 6 commits into
base: main
Choose a base branch
from
+245 −14
Open

fix(dotnet): identify deps.json root project from dependency graph #10954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6cb3e1
fix(dotnet): select deps.json root project deterministically
jetersen Jul 11, 2026
e8a1691
fix(dotnet): identify root project from dependency graph
jetersen Jul 13, 2026
5128c87
test(dotnet): retain multi-project solution fixture
jetersen Jul 13, 2026
058762e
fix(dotnet): classify project references as workspace
jetersen Jul 14, 2026
296221c
fix(dotnet): handle ambiguous root relationships
jetersen Jul 14, 2026
a5d3e9a
test(dotnet): flatten multi-project fixture path
jetersen Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/dependency/parser/dotnet/core_deps/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package core_deps

import (
"context"
"maps"
"slices"
"sort"
"strings"
Expand Down Expand Up @@ -104,7 +105,8 @@ func (p *Parser) collectPackages(depsFile dotNetDependencies, targetLibs map[str
var projectNameVer string
pkgs := make(map[string]ftypes.Package, len(depsFile.Libraries))

for nameVer, lib := range depsFile.Libraries {
for _, nameVer := range slices.Sorted(maps.Keys(depsFile.Libraries)) {
lib := depsFile.Libraries[nameVer]
name, version, ok := strings.Cut(nameVer, "/")
if !ok {
// Invalid name
Expand Down
17 changes: 17 additions & 0 deletions pkg/dependency/parser/dotnet/core_deps/parse_test.go
View file
Open in desktop
Comment thread
jetersen marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -241,3 +241,20 @@ func TestParse(t *testing.T) {
})
}
}

func TestCollectPackagesDeterministicRoot(t *testing.T) {
depsFile := dotNetDependencies{
Libraries: map[string]dotNetLibrary{
"Zebra/1.0.0": {Type: "project"},
"Mango/1.0.0": {Type: "project"},
"Alpha/1.0.0": {Type: "project"},
},
}

// The lexicographically first project library must win regardless of
// map iteration order.
pkgs, root := NewParser().collectPackages(depsFile, nil, false)

assert.Equal(t, "Alpha/1.0.0", root)
assert.Equal(t, ftypes.RelationshipRoot, pkgs[root].Relationship)
}
Loading