fix(conda): avoid panic on an all-operator dependency line#10955
Open
arpitjain099 wants to merge 1 commit into
Open
fix(conda): avoid panic on an all-operator dependency line#10955arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
DmitriyLewen
left a comment
Contributor
There was a problem hiding this comment.
Hello @arpitjain099
Thanks for the fix — it's correct and minimal. One request before merging: please add a regression test for the fixed path.
Right now the panicking input isn't covered by any case, so if the guard is ever accidentally removed or broken, the tests won't catch it and the panic will come back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseDependencynormalizes a condaenvironment.ymldependency string by turning the version operators into spaces, then splits on whitespace and readsparts[0]:If the dependency value is only operators, e.g. a stray
"=", the replaced line is all whitespace andstrings.Fieldsreturns an empty slice, soparts[0]panics with an index-out-of-range and aborts the scan.Repro (
environment.yml):"="is a valid YAML string scalar, so it reachesparseDependency. The sibling text parsers (golang/sum,ruby/bundler,rust/cargo) all guard the empty-split case before indexing; conda did not.The fix returns an empty name/version for such a line, which the caller already drops via its existing
if pkg.Name == "" { continue }.go test ./pkg/dependency/parser/conda/...passes.