Add Korean (Hangul) language practice with 2-set Dubeolsik layout - #619
Open
MadanChaollaPark wants to merge 2 commits into
Open
Add Korean (Hangul) language practice with 2-set Dubeolsik layout#619MadanChaollaPark wants to merge 2 commits into
MadanChaollaPark wants to merge 2 commits into
Conversation
Practice Korean as jamo keystrokes so progressive lessons and per-key stats match how 2-set Hangul is typed. Includes Language.KO, ko-kr layout, dictionary, phonetic model, word list, hangul font script support, and FORK.md usage notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Korean as a practice language using 2-set (두벌식) jamo keystrokes, so progressive lessons and per-key stats match how Hangul is typed on a 2-set keyboard.
Language.KO(hangulscript, 33 compatibility jamo)ko-kr/{KR} (두벌식)with layout emulationIntlYenlabel →₩Complex vowels/finals are decomposed into the keys actually pressed (e.g.
ㅘ→ㅗㅏ).Why jamo (not composed syllables)?
keybr’s model is per-letter. Hangul syllables would explode the alphabet (~11k). Jamo keystrokes match the keys on 2-set and keep progressive unlocking workable.
Test plan
npm --workspace packages/keybr-keyboard run test(includeskorean jamo words,ko-kr/*layouts)npm --workspace packages/keybr-content-words run test(words:ko)npm --workspace packages/keybr-phonetic-model run test(komodel)Refs: #259