Porting the TypeScript tests into solidity - #686
Conversation
3d9230b to
498c563
Compare
e3ef005 to
5e3c8f3
Compare
c867813 to
1fbca0e
Compare
7450586 to
5e2bf9e
Compare
xavikh
left a comment
There was a problem hiding this comment.
Solid port overall: builds clean, 896 tests pass. Detailed findings are inline. One thing up front that needs a call before merge:
Managing-DAO post-deployment checks were dropped with no replacement. The old deploy/managing-dao.ts (7 cases) verified the live managing DAO holds ROOT on itself and upgrade permission over the registries/registrars. A fork test against mainnet is the natural home (the pattern already exists in test/framework/member/fork/). Land it here or as a follow-up?
These tests belong in the Protocol Factory, since it is what does the whole orchestration of Core + Plugins. The Management DAO cannot exist without the Multisig plugin setup being available I wouldn't introduce downstream dependencies here. |
Description
Also: