cross chain simplify - #698
Merged
giorgilagidze merged 1 commit intoJul 24, 2026
Merged
Conversation
xavikh
reviewed
Jul 24, 2026
| @@ -433,10 +315,10 @@ contract CrossChainController is DaoAuthorizable { | |||
| function retryFailedMessage( | |||
There was a problem hiding this comment.
We have a small issue with failed messages and is that they stay executable forever. So a future change, even 1 year after can make the message executable. We might need to add a timestamp/deadline to the messages or to the failed ones to only allow retries for X amount of time.
| @@ -433,10 +315,10 @@ contract CrossChainController is DaoAuthorizable { | |||
| function retryFailedMessage( | |||
| bytes32 _callId | |||
| ) public auth(RETRY_MESSAGE_PERMISSION_ID) { | |||
There was a problem hiding this comment.
I think we can consider opening the retry to anyone. Interesting enough if the DAO tries to retry it would fail due to reentrancy (DAO.execute() --> retry() -X-> DAO.execute), so the call has to come from another address.
There was a problem hiding this comment.
Let's make sure we add a way to pause the send/receive/retry functions
giorgilagidze
merged commit Jul 24, 2026
2791801
into
fix/crosschain-hardening-delegatecall
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description