docs: fix dead links, toolchain gaps, and document index - #402
Conversation
- Fix CHANGELOG dead links: docs/ARCHITECTURE.md -> docs/architecture/, and src/conf/kiwi.conf -> kiwi --sample-config generation - Complete English README Prerequisites: add macOS cmake and full Linux C/C++ toolchain (clang, cmake, libclang-dev, llvm-dev, pkg-config); add Windows protoc parity note - Unify docs/development.md Python integration test commands to `make -C tests install-deps` + `make -C tests test-python` - Complete README documentation tables (en/cn): prd, quality-gates, personas, docs index, superpowers - Add Implementation Status section linking code-review-findings.md - Add docs/INDEX.md reading roadmap - Fix placeholder image alt text in docs/key-encoding.md - Include code-review-findings.md so the new status link resolves
📝 WalkthroughWalkthroughThe pull request updates project documentation, configuration instructions, platform prerequisites, the documentation index, Python integration-test workflow, migration guidance, and encoding diagram references. ChangesDocumentation Updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 105: Update the architecture reference in CHANGELOG.md to use clickable
Markdown link syntax targeting docs/architecture/. Preserve the existing wording
while making the documentation directly navigable.
In `@code-review-findings.md`:
- Around line 4-5: Align the review scope and completion statements in
code-review-findings.md: make the crate list match the claimed 13-crate
coverage, and update the section around the Raft-focused review so it no longer
both omits raft and marks that review as pending. If Raft was not reviewed,
narrow the overall scope and completion claims consistently instead.
- Around line 1-5: Make the dated-record claim accurate by adding explicit
review or update date metadata near the title in code-review-findings.md. In
README.md lines 63-66 and docs/INDEX.md lines 10-15, retain the “dated” wording
only when referring to that metadata; otherwise remove or revise the wording so
both descriptions match the source document.
In `@docs/INDEX.md`:
- Around line 22-27: Update the planning-file list in the documentation index so
both OPEN_QUESTIONS.md and REFERENCES.md use the .planning/ prefix, matching
DECISIONS.md and all other entries. Preserve the existing descriptions and
formatting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8d4aeb36-948e-44d4-90ad-303e56230429
📒 Files selected for processing (7)
CHANGELOG.mdREADME.mdREADME_CN.mdcode-review-findings.mddocs/INDEX.mddocs/development.mddocs/key-encoding.md
Remove the unverified review report and its authoritative-entry links. Correct sample-config redirection, isolated Python integration instructions, planning paths, design-history pairing guidance, and architecture links. Tested: git diff --cached --check; local Markdown link target scan; bash -n on the committed integration-runner blob; changed-path ownership check. Not-tested: Rust builds and tests were not rerun because this follow-up changes documentation only; the new Head will be validated by GitHub CI after push. Co-authored-by: OmX <omx@oh-my-codex.dev>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
144-145: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep sample-configuration commands separate from document links.
Both README files place shell commands in tables labeled for documents. Use a dedicated configuration subsection and code block, or rename the table schema to support mixed resources.
README.md#L144-L145: move the two sample-configuration commands to a dedicated configuration section.README_CN.md#L145-L146: apply the same structural change in the Chinese README.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 144 - 145, Move the sample-configuration command entries from the document-links table into a dedicated configuration subsection or code block in README.md (lines 144-145) and README_CN.md (lines 145-146), preserving both commands and their descriptions while keeping the document tables limited to document links.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Around line 144-145: Move the sample-configuration command entries from the
document-links table into a dedicated configuration subsection or code block in
README.md (lines 144-145) and README_CN.md (lines 145-146), preserving both
commands and their descriptions while keeping the document tables limited to
document links.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 73a5345c-542e-4cdb-ad52-9f361fa6ee72
📒 Files selected for processing (5)
CHANGELOG.mdREADME.mdREADME_CN.mddocs/INDEX.mddocs/development.md
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/INDEX.md
- CHANGELOG.md
Resolve PR #404 against main after PRs #402, #403, #405, and #406 while preserving RESP resource budgets, declaration-independent aggregate growth, bounded pipeline admission, and one shared request deadline. Constraint: Preserve the verified PR #404 scope and publish without force-push Tested: Windows resp 80 unit and 20 integration tests; net 35 lib tests; WSL resp and net suites, TCP regressions, strict Clippy; cargo fmt and diff checks Co-authored-by: OmX <omx@oh-my-codex.dev>
Summary
Documentation maintenance fixes based on a full review of the Kiwi doc tree. No code changes.
Dead links fixed (P0)
CHANGELOG.md:docs/ARCHITECTURE.md→docs/architecture/(×2);src/conf/kiwi.conf→kiwi --sample-configgeneration (×2). Neitherdocs/ARCHITECTURE.mdnorsrc/conf/kiwi.confexists in the repo.Toolchain completeness (P0)
README.md(English) Prerequisites was missing macOScmakeand the entire Linux C/C++ toolchain, which would break the from-source RocksDB build. Now matches the Chinese README (brew install protobuf cmake+sudo apt install clang cmake libclang-dev llvm-dev pkg-config protobuf-compiler), and adds a Windows protoc parity note.Consistency (P1)
docs/development.md: Python integration test commands updated to the project-canonicalmake -C tests install-deps+make -C tests test-python(was the outdatedpip install redis pytest+pytest tests/python/).README.md/README_CN.mdDocumentation tables: added missing rows fordocs/prd.md,docs/quality/quality-gates.md,docs/personas-and-user-stories.md,docs/INDEX.md, anddocs/superpowers/.code-review-findings.md, making that previously-unreferenced review record discoverable and clarifying that Redis 8.8.1 compatibility is an in-progress goal.Discoverability / hygiene (P2)
docs/INDEX.md— a map of the wholedocs/tree with a suggested reading order by audience.img.pngalt text indocs/key-encoding.md.code-review-findings.md(was untracked) so the new status link resolves.Test plan
grepconfirms zero remainingdocs/ARCHITECTURE.md/src/conf/kiwi.confreferences across all.md.🤖 Generated with WorkBuddy
Summary by CodeRabbit