Skip to content

Use LinkedHashMap instead of HashMap for reproducible output files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpenilla wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use LinkedHashMap instead of HashMap for reproducible output files #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/dev/architectury/at/impl/AccessTransformSetImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
import net.fabricmc.mappingio.tree.MappingTreeView;

import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;

public class AccessTransformSetImpl implements AccessTransformSet {

private final Map<String, Class> classes = new HashMap<>();
private final Map<String, Class> classes = new LinkedHashMap<>();

@Override
public Map<String, Class> getClasses() {
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/dev/architectury/at/impl/ClassAccessTransformSetImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import org.cadixdev.bombe.type.signature.MethodSignature;

import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Objects;
import java.util.StringJoiner;
Expand All @@ -45,8 +45,8 @@ class ClassAccessTransformSetImpl implements AccessTransformSet.Class {
private AccessTransform allFields = AccessTransform.EMPTY;
private AccessTransform allMethods = AccessTransform.EMPTY;

private final Map<String, AccessTransform> fields = new HashMap<>();
private final Map<MethodSignature, AccessTransform> methods = new HashMap<>();
private final Map<String, AccessTransform> fields = new LinkedHashMap<>();
private final Map<MethodSignature, AccessTransform> methods = new LinkedHashMap<>();

private boolean complete;

Expand Down