Properly set search string in Global Search - #2763
Merged
Merged
Conversation
Contributor
|
You should replace |
Tofandel
reviewed
Jul 31, 2025
Co-authored-by: Adrien Foulon <6115458+Tofandel@users.noreply.github.com>
ifox
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
cmsSearch()method in ModuleController uses the FreeTextSearch model and sets:The FreeTextSearch model, however, has a condition that requires
searchStringto not be empty, and that value is never set in cmsSearch(). It gets set by thesearchFor()method which never gets called.Adding:
Makes global search work as expected for me.
Related Issues
Fixes #2762