Align imported ARENA renderer color space defaults with Linear - #165
Conversation
Architectural Code Review — PR #165Linked IssueIssue #150 — "Adjust Gamma Color Space"
SummaryChanges the default Issue → Implementation Gap Analysis
CONTRIBUTING.md Compliance
Architecture Assessment✅ Warning message improvement is excellent. The new message includes:
✅ Tooltip update is appropriate. Changing from "three.js default is SRGBColorSpace" to "ARENA web scenes commonly use LinearSRGBColorSpace" better reflects the actual ARENA ecosystem expectation. ❌ Blocking Finding: Default Change Contradicts arena-schemasThe arena-schemas canonical source defines the default as This PR changes the arena-unity default to
Recommendation: Either:
Verdict: ❌ BLOCKED — default conflicts with arena-schemasThe warning message improvement is great and should be merged. But the default change needs to be reconciled with arena-schemas first to avoid cross-client color space disagreement. |
arena-schemas defines SRGBColorSpace as the default outputColorSpace. Keep the improved warning message and tooltip but align the default with the canonical schema source to avoid cross-client mismatch.
ARENA web scenes commonly assume Linear color space, while some Unity projects are configured for Gamma. That mismatch can make imported scenes render darker or with different light falloff than intended.
Renderer default alignment
renderer-settings.outputColorSpacedefault fromSRGBColorSpacetoLinearSRGBColorSpaceMismatch diagnostics
renderer-settingsdarker colors/different light falloff) and points directly to the Unity Player setting to updateSchema metadata
outputColorSpacetooltip text to reflect the ARENA-side expectation instead of the previous sRGB wordingExample: