Skip to content

feat: add finalizers field#635

Draft
blakepettersson wants to merge 3 commits intoargoproj-labs:mainfrom
blakepettersson:feature/add-finalizers-field
Draft

feat: add finalizers field#635
blakepettersson wants to merge 3 commits intoargoproj-labs:mainfrom
blakepettersson:feature/add-finalizers-field

Conversation

@blakepettersson
Copy link
Copy Markdown
Collaborator

@blakepettersson blakepettersson commented Apr 30, 2025 •
edited
Loading

Finalizers are a valid field for projects, apps and appsets.

Fixes #391 and #404.

@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 98d38d2 to 41a2e9e Compare April 30, 2025 07:58
This was referenced Apr 30, 2025
Open
Open
@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 41a2e9e to 9355f54 Compare April 30, 2025 08:06
@blakepettersson
Copy link
Copy Markdown
Collaborator Author

blakepettersson commented Apr 30, 2025

This comment means that it's not as trivial as just adding the field. I don't think it's a massive hurdle, but gives some food for thought.

@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch 3 times, most recently from 0ded718 to ec4ab16 Compare April 30, 2025 09:39
@mkilchhofer mkilchhofer linked an issue May 6, 2025 that may be closed by this pull request
While creating appproject how we can add finalizers in the argocd_project resource #404
Open
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 29, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue didn't had recent activity and will be closed soon label Jun 29, 2025
@blakepettersson blakepettersson removed the Stale Issue didn't had recent activity and will be closed soon label Jun 29, 2025
@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 337c85e to e739d9a Compare June 29, 2025 17:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue didn't had recent activity and will be closed soon label Sep 12, 2025
@gperreymond
Copy link
Copy Markdown

gperreymond commented Sep 13, 2025

hello
any update for finalizers ?
because when you delete an app, all resources stay in place, so i continue to use manifest.

@github-actions github-actions bot removed the Stale Issue didn't had recent activity and will be closed soon label Sep 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue didn't had recent activity and will be closed soon label Dec 12, 2025
@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 3cb7bad to 4ed6884 Compare December 18, 2025 23:17
@blakepettersson blakepettersson removed the Stale Issue didn't had recent activity and will be closed soon label Dec 18, 2025
@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 9d96c0e to 6c70825 Compare December 19, 2025 07:38
@blakepettersson
feat: add finalizers field
b67723d 
Finalizers are a valid field for projects, apps and appsets.

Fixes argoproj-labs#391 and argoproj-labs#404.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson force-pushed the feature/add-finalizers-field branch from 29149ab to b67723d Compare January 11, 2026 13:11
@blakepettersson
refactor: use strings.join
c53c795 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson
chore: please linter
45aeaab 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue didn't had recent activity and will be closed soon label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oboukili oboukili Awaiting requested review from oboukili oboukili will be requested when the pull request is marked ready for review oboukili is a code owner

@onematchfox onematchfox Awaiting requested review from onematchfox onematchfox will be requested when the pull request is marked ready for review onematchfox is a code owner

@the-technat the-technat Awaiting requested review from the-technat the-technat will be requested when the pull request is marked ready for review the-technat is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer will be requested when the pull request is marked ready for review mkilchhofer is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Stale Issue didn't had recent activity and will be closed soon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

While creating appproject how we can add finalizers in the argocd_project resource add support for finalizers in metadata.

2 participants

@blakepettersson @gperreymond