Skip to content

fix(bitbucketserver): replace %w with %v in Logger.Errorf call#3990

Open
dongjune8931 wants to merge 1 commit intoargoproj:masterfrom
dongjune8931:fix/bitbucketserver-errorf-format-verb
Open

fix(bitbucketserver): replace %w with %v in Logger.Errorf call#3990
dongjune8931 wants to merge 1 commit intoargoproj:masterfrom
dongjune8931:fix/bitbucketserver-errorf-format-verb

Conversation

@dongjune8931
Copy link
Copy Markdown

Checklist:

Logger.Errorf is backed by zap.SugaredLogger, which uses fmt.Sprintfinternally. The %w verb is only meaningful in fmt.Errorf for error wrapping — passing it to Logger.Errorf produces a garbled log line like
%!w(*errors.errorString=&{...}) instead of the actual error message.

Replace %w with %v to produce a human-readable log output, consistent with how other event sources in this codebase handle error logging.

Fixes #3989

@dongjune8931 dongjune8931 requested a review from whynowy as a code owner April 8, 2026 11:36
Signed-off-by: dongjune8931 <ldj990517@gmail.com>
@dongjune8931 dongjune8931 force-pushed the fix/bitbucketserver-errorf-format-verb branch from 9cfa75d to 552ae31 Compare April 8, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bitbucket Server event source logs garbled error message due to incorrect %w verb in Logger.Errorf

1 participant