fix(ui): workflow list sidebar filter correctly update URL query parameters for multi-value. Fixes #15213#16139
Draft
myzk-a wants to merge 7 commits into
Draft
Conversation
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15213
Motivation
The Workflows list page does not correctly update URL query parameters when using multi-value filters (Phase, Labels):
Modifications
This PR continues the work from #15217. Thanks to the original author for the investigation and implementation in that PR.
historyUrlby appendingextraSearchParamsinstead of replacing existing values with the same key.offset,limit, name filter,createdAfter, andfinishedBefore) as single values when rebuilding the URL.extraSearchParamsinhistoryUrl.Verification
test-multiple-phases.mp4
test-multiple-labels.mp4
Documentation
AI
I used Codex(v0.133.0) to help understand the related issue and pull request context, including #15213 and #15217, and to help prepare the test code for this change.