Skip to content

fix(ui): workflow list sidebar filter correctly update URL query parameters for multi-value. Fixes #15213#16139

Draft
myzk-a wants to merge 7 commits into
argoproj:mainfrom
myzk-a:fix-workflow-phase-labels-queryparameters
Draft

fix(ui): workflow list sidebar filter correctly update URL query parameters for multi-value. Fixes #15213#16139
myzk-a wants to merge 7 commits into
argoproj:mainfrom
myzk-a:fix-workflow-phase-labels-queryparameters

Conversation

@myzk-a
Copy link
Copy Markdown

@myzk-a myzk-a commented May 23, 2026

Fixes #15213

Motivation

The Workflows list page does not correctly update URL query parameters when using multi-value filters (Phase, Labels):

  1. Multiple selections not preserved: Selecting multiple phases (e.g., Running + Failed) only shows the last one in the URL
  2. Unchecking not reflected: Unchecking a filter doesn't remove it from the URL

Modifications

This PR continues the work from #15217. Thanks to the original author for the investigation and implementation in that PR.

  • Preserve repeated query parameters passed through historyUrl by appending extraSearchParams instead of replacing existing values with the same key.
  • Keep single-value Workflows list query parameters (offset, limit, name filter, createdAfter, and finishedBefore) as single values when rebuilding the URL.
  • Add tests for repeated extraSearchParams in historyUrl.
  • Add Workflows list tests that verify:
    • selecting multiple phase and label filters adds repeated query parameters to the URL;
    • removing one selected phase and one selected label removes only the corresponding query parameters;
    • opening a URL with repeated phase and label query parameters restores the selected filters in the UI.

Verification

  • Selecting multiple phases should be reflected in the URL.
  • Deselecting a phase should be reflected in the URL.
test-multiple-phases.mp4
  • Selecting multiple labels should be reflected in the URL.
  • Deselecting a label should be reflected in the URL.
test-multiple-labels.mp4

Documentation

AI

I used Codex(v0.133.0) to help understand the related issue and pull request context, including #15213 and #15217, and to help prepare the test code for this change.

myzk-a added 5 commits May 23, 2026 08:28
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
Signed-off-by: myzk-a <rorosocksxion@gmail.com>
@myzk-a

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Workflows list Phase/Labels filters not correctly reflected in URL

1 participant