Support for hardhat/foundry console output#1050
Open
gustavo-grieco wants to merge 9 commits intomainfrom
Open
Conversation
This was referenced Mar 27, 2026
msooseth
reviewed
Apr 1, 2026
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
LGTM, but can you maybe give more explanation at the top of the PR what this is about? I am not very familiar with hardhat. Then I'll approve and we can merge!
Collaborator
Author
|
Added some description to this PR. |
blishko
requested changes
Apr 2, 2026
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
The tests need additional work.
EXTCODESIZE now returns 1 for the console address (matching cheatCode behavior), so contracts that check code size before calling won't skip the console.log call. Added 8 new tests covering EXTCODESIZE, format decoding (bool, address, no-args, unknown selector, short input), return value correctness, and multiple console.log calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
I did a thing -- adding more tests, changelog, and also one more place where a hardcoded address should be checked maybe? |
The test contract files were not tracked in git, causing CI failures since the Nix build only includes git-tracked files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
@blishko can you maybe re-review and then we can merge? Thanks! |
blishko
reviewed
Apr 8, 2026
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
The unit tests should be moved, otherwise should be good to go!
Comment on lines
+93
to
+118
| [ testCase "format-string" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log(string)" (AbiTuple $ V.fromList [AbiString "hello world"]) | ||
| assertEqual "console.log(string) format" "console::log(\"hello world\")" (formatConsoleLog encoded) | ||
| , testCase "format-uint" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log(uint256)" (AbiTuple $ V.fromList [AbiUInt 256 42]) | ||
| assertEqual "console.log(uint256) format" "console::log(42)" (formatConsoleLog encoded) | ||
| , testCase "format-string-uint" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log(string,uint256)" (AbiTuple $ V.fromList [AbiString "count", AbiUInt 256 7]) | ||
| assertEqual "console.log(string,uint256) format" "console::log(\"count\", 7)" (formatConsoleLog encoded) | ||
| , testCase "format-bool" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log(bool)" (AbiTuple $ V.fromList [AbiBool True]) | ||
| assertEqual "console.log(bool) format" "console::log(true)" (formatConsoleLog encoded) | ||
| , testCase "format-address" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log(address)" (AbiTuple $ V.fromList [AbiAddress 0xdeadbeef]) | ||
| assertEqual "console.log(address) format" "console::log(0x00000000000000000000000000000000DeaDBeef)" (formatConsoleLog encoded) | ||
| , testCase "format-no-args" $ do | ||
| let encoded = ConcreteBuf $ abiMethod "log()" (AbiTuple $ V.fromList []) | ||
| assertEqual "console.log() format" "console::log()" (formatConsoleLog encoded) | ||
| , testCase "format-unknown-selector" $ do | ||
| let encoded = ConcreteBuf $ BS.pack [0xde, 0xad, 0xbe, 0xef, 0x01, 0x02] | ||
| let result = formatConsoleLog encoded | ||
| assertBool "unknown selector should produce hex fallback" (T.isPrefixOf "console::log(0x" result) | ||
| , testCase "format-short-input" $ do | ||
| let encoded = ConcreteBuf $ BS.pack [0x01, 0x02] | ||
| assertEqual "short input format" "console::log()" (formatConsoleLog encoded) | ||
| ] |
Collaborator
There was a problem hiding this comment.
These tests should be moved elsewhere.
They do not test concrete VM executions (which is the purpose of this file), they are just unit tests for formatConsoleLog.
Not sure what is the best place for them, we can move them to the main test.hs for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implement console logging in the same way Foundry did (and Hardhat initially). The feature is explained here. This will help to fix crytic/echidna#1233.
Checklist