Skip to content

Parse correctly enumerated types #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavo-grieco wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parse correctly enumerated types #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/EVM/ABI.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,11 @@ basicType v =
, P.string "bytes" $> AbiBytesDynamicType
, P.string "tuple" $> AbiTupleType v
, P.string "function" $> AbiFunctionType

-- Fallback for user-defined types (e.g. enums like "Order.OrderType").
-- Solidity libraries emit qualified enum names in their ABI instead of
-- the underlying uint8. Treat any unrecognized identifier as uint8.
, P.try (P.some (P.alphaNumChar P.<|> P.char '.') $> AbiUIntType 8)
]

where
Expand Down
9 changes: 9 additions & 0 deletions test/test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,15 @@ tests = testGroup "hevm"
case readP_to_S (parseAbiValue (AbiBytesType 4)) threeBytes of
[] -> pure () -- Expected: parsing should fail
_ -> internalError "Should reject 3-byte value for bytes4"
, test "ABI-user-defined-enum-type" $ do
Copy link
Copy Markdown
Collaborator

@blishko blishko Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename this to ABI-parsing-types? And add tests for all the standard types?

-- User-defined types like enums (e.g. "Order.OrderType") should parse as uint8
assertEqualM "qualified enum" (Just (AbiUIntType 8)) (parseTypeName mempty "Order.OrderType")
assertEqualM "simple enum" (Just (AbiUIntType 8)) (parseTypeName mempty "MyEnum")
-- Should also work with array suffixes
assertEqualM "enum array" (Just (AbiArrayDynamicType (AbiUIntType 8))) (parseTypeName mempty "Order.OrderType[]")
-- Standard types should still work
assertEqualM "uint256" (Just (AbiUIntType 256)) (parseTypeName mempty "uint256")
assertEqualM "address" (Just AbiAddressType) (parseTypeName mempty "address")
]
, testGroup "Solidity-Expressions"
[ test "Trivial" $
Expand Down
Loading