Skip to content

Fix pattern matching#347

Open
Y-Nak wants to merge 4 commits intoargotorg:mainfrom
Y-Nak:fix-pattern-matching
Open

Fix pattern matching#347
Y-Nak wants to merge 4 commits intoargotorg:mainfrom
Y-Nak:fix-pattern-matching

Conversation

@Y-Nak
Copy link
Copy Markdown
Member

@Y-Nak Y-Nak commented Apr 6, 2026 •
edited
Loading

  • Fix a crash when a variable-only match branch contains multiple statements
  • Avoid duplicating scrutinee evaluation in variable match branches
  • Limit ormolu check to tracked source directories

@Y-Nak Y-Nak requested a review from rodrigogribeiro April 6, 2026 13:06
@Y-Nak Y-Nak force-pushed the fix-pattern-matching branch from cd9c08c to a661462 Compare April 6, 2026 13:18
@mbenke
Copy link
Copy Markdown
Collaborator

mbenke commented Apr 7, 2026

Maybe we should consider adding a block statement to the abstract syntax(es). I do not feel good about the Match [] [([], body)] hack.

rodrigogribeiro
rodrigogribeiro approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rodrigogribeiro rodrigogribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigogribeiro rodrigogribeiro rodrigogribeiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Y-Nak @mbenke @rodrigogribeiro