Add implicit contract constructor if no explicit one defined#350
Open
Add implicit contract constructor if no explicit one defined#350
Conversation
Y-Nak
approved these changes
Apr 13, 2026
Member
Y-Nak
left a comment
Y-Nak
left a comment
There was a problem hiding this comment.
LGTM.
One thing I realized is that if a contract has a start function, then a compilation fails; Duplicated function definition:start.
This is not directly related to this PR, but we might need to consider how to lower the constract constructor.
Collaborator
Author
|
@Y-Nak thanks, good catch! This is a bigger change then it seemed at first glance though, so I'll do that in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dispatch generation add a default empty constructor to the contract if it does not have one.
Should also remove many '!! Warning: no resolution found for start' encountered when running tests (most of which have no sonstructor, or no contract even).