fix(review): correct Alpine pinning rule in REVIEW.md#516
Merged
Conversation
Contributor
Ansible Container Tests Summary — ✅ SUCCESS
Statistical Summary
Environment Information
|
REVIEW.md required 'version ranges, never exact patch pins', which contradicts the actual convention (AGENTS.md + Dockerfile): Alpine packages use exact pins (pkg=version-rN) via the pkg.arillso.io proxy. Align the review checklist with the real policy.
The pull-request workflow used on.pull_request.paths-ignore for **.md and LICENSE, so a docs-only PR did not trigger the workflow at all. The repo ruleset requires the 'Test Summary' status check, which therefore never ran and never reported, leaving such PRs permanently un-mergeable. This is a structural deadlock: paths-ignore and a required status check are mutually exclusive. Remove paths-ignore so the workflow runs on every PR, and add a 'changes' gate job (dorny/paths-filter) that detects whether any non-doc files were touched. The heavy jobs (lint, prepare, build, *-test) now need the gate and run only when code == 'true'. The test-summary job keeps if: always() and emits a short 'docs-only' success path when no code changed, so the required 'Test Summary' check always reports green. claude-review and security-secrets stay ungated and keep running on docs-only PRs. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
sbaerlocher
force-pushed
the
fix/review-pinning-rule
branch
from
74972b3 to
a37525f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REVIEW.mdinstructed reviewers that Alpine packages should use "version ranges, never exact patch pins" — the exact opposite of the real convention.Per
AGENTS.mdand theDockerfile, Alpine packages must use exact pins (pkg=version-rN), resolved through the pkg.arillso.io caching proxy and bumped by Renovate. The stale rule would lead reviewers to flag correct pins as wrong.Why
Surfaced during a repo-standard audit of all arillso repositories.
Test plan