Skip to content

Fix license metadata mismatch: use PackageLicenseFile for custom Ms-PL/Modified license#125

Merged
cerebrate merged 2 commits into
devfrom
copilot/sub-pr-123-again
Feb 28, 2026
Merged

Fix license metadata mismatch: use PackageLicenseFile for custom Ms-PL/Modified license#125
cerebrate merged 2 commits into
devfrom
copilot/sub-pr-123-again

Conversation

Copilot AI commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

The .csproj declared <PackageLicenseExpression>MIT</PackageLicenseExpression>, but the actual LICENSE file is a modified Ms-PL with a custom "Special Usage Limitation" clause (Section 4) — neither MIT nor expressible as a standard SPDX identifier.

Changes

  • MouseJiggler/MouseJiggler.csproj
    • Replace PackageLicenseExpression (SPDX MIT) with PackageLicenseFile referencing the actual LICENSE file
    • Add LICENSE to the NuGet pack ItemGroup alongside README.md
<!-- Before -->
<PackageLicenseExpression>MIT</PackageLicenseExpression>

<!-- After -->
<PackageLicenseFile>LICENSE</PackageLicenseFile>
...
<None Include="..\LICENSE">
  <Pack>True</Pack>
  <PackagePath>\</PackagePath>
</None>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…geLicenseFile

Co-authored-by: cerebrate <371623+cerebrate@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback from review on 3.0.0 milestone PR Fix license metadata mismatch: use PackageLicenseFile for custom Ms-PL/Modified license Feb 28, 2026
@cerebrate cerebrate marked this pull request as ready for review February 28, 2026 05:51
Copilot AI review requested due to automatic review settings February 28, 2026 05:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NuGet package metadata so the published package points to the repository’s actual (non-SPDX) license text instead of incorrectly claiming an MIT SPDX expression.

Changes:

  • Replace PackageLicenseExpression with PackageLicenseFile in the project’s NuGet metadata.
  • Include the repository root LICENSE file in the packed NuGet contents (alongside the already-packed README.md).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cerebrate cerebrate merged commit 889e610 into dev Feb 28, 2026
4 checks passed
@cerebrate cerebrate deleted the copilot/sub-pr-123-again branch February 28, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants