Skip to content

fix: Fixed CORS headers in dataproxy, authors in server#202

Merged
lfbrehm merged 2 commits into
mainfrom
fix/cors
Aug 11, 2025
Merged

fix: Fixed CORS headers in dataproxy, authors in server#202
lfbrehm merged 2 commits into
mainfrom
fix/cors

Conversation

@lfbrehm

@lfbrehm lfbrehm commented Aug 11, 2025

Copy link
Copy Markdown
Member

Fixed:

  • When OPTIONS requests are made, bucket-specific CORS configurations are returned
  • Only CORS headers for ORIGIN are returned
  • Authors are now also updated in database
  • CORS headers are either set or deleted, not both

@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.60000% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.68%. Comparing base (082e497) to head (6a79c0e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
components/data_proxy/src/s3_frontend/s3server.rs 0.00% 102 Missing ⚠️
components/data_proxy/src/s3_frontend/s3service.rs 0.00% 8 Missing ⚠️
components/server/src/database/dsls/object_dsl.rs 20.00% 8 Missing ⚠️
...nents/data_proxy/src/caching/grpc_query_handler.rs 0.00% 4 Missing ⚠️
...onents/server/src/middlelayer/update_db_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   32.93%   32.68%   -0.26%     
==========================================
  Files         127      127              
  Lines       23197    23287      +90     
  Branches    23197    23287      +90     
==========================================
- Hits         7640     7611      -29     
- Misses      14574    14693     +119     
  Partials      983      983              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@das-Abroxas das-Abroxas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improval. Looks good 👍

@lfbrehm
lfbrehm merged commit 433340e into main Aug 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants