Skip to content

Fix/cors#203

Merged
lfbrehm merged 12 commits into
mainfrom
fix/cors
Aug 13, 2025
Merged

Fix/cors#203
lfbrehm merged 12 commits into
mainfrom
fix/cors

Conversation

@lfbrehm

@lfbrehm lfbrehm commented Aug 13, 2025

Copy link
Copy Markdown
Member

Updated dependencies and fixed path style handling for OPTIONS requests.
Also fixed a testing related postgres deadlock.

@codecov

codecov Bot commented Aug 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.25000% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.84%. Comparing base (433340e) to head (a4e61af).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
components/data_proxy/src/s3_frontend/s3server.rs 0.00% 22 Missing ⚠️
components/data_proxy/src/s3_frontend/s3service.rs 0.00% 14 Missing ⚠️
...s/data_proxy/src/data_backends/location_handler.rs 0.00% 5 Missing ⚠️
components/server/src/utils/grpc_utils.rs 83.33% 5 Missing ⚠️
components/server/src/database/connection.rs 0.00% 4 Missing ⚠️
...nents/data_proxy/src/caching/grpc_query_handler.rs 0.00% 1 Missing ⚠️
...ponents/data_proxy/src/data_backends/s3_backend.rs 0.00% 1 Missing ⚠️
components/data_proxy/src/s3_frontend/auth.rs 0.00% 1 Missing ⚠️
components/data_proxy/src/structs.rs 0.00% 1 Missing ⚠️
components/server/src/notification/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   32.85%   32.84%   -0.02%     
==========================================
  Files         127      127              
  Lines       23287    23356      +69     
  Branches    23287    23356      +69     
==========================================
+ Hits         7651     7671      +20     
- Misses      14653    14711      +58     
+ Partials      983      974       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@das-Abroxas das-Abroxas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

On a side note, we should write a few tests for the added functionality in the future.

@lfbrehm lfbrehm merged commit 13462a6 into main Aug 13, 2025
6 checks passed
@St4NNi St4NNi deleted the fix/cors branch April 23, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants