Conversation
das-Abroxas
reviewed
Jun 29, 2026
das-Abroxas
left a comment
Contributor
There was a problem hiding this comment.
I left some comments which are not mission critical. Address these issues or just leave a comment why you don't think that this is necessary and I will approve this PR ✌️
das-Abroxas
previously approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Nice. There are still a few minor things that could be improved, such as using the header name constants from the http crate (e.g. http::header::ORIGIN) instead of defining them again ourselves. But, those are just design decision discussions at this point. lgtm.
das-Abroxas
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CORS support for browser-based access to Aruna through both the REST API and S3 interface. It also integrates bucket-level S3 CORS configuration support from
feat/bucket-cors.Changes
BucketInfo. (This includes the changes from the branchfeat/bucket_cors)PutBucketCors,GetBucketCors, andDeleteBucketCors.Fixed Issues
Fixes #242
Fixes #244