Harden metadata sync placement and clock skew handling#299
Merged
Conversation
das-Abroxas
approved these changes
Jun 30, 2026
das-Abroxas
left a comment
Contributor
There was a problem hiding this comment.
Nice to have clock-skew protection to prevent (malicious) last-writer-wins metadata event conflicts. Also good, that User nodes are now exempt from sync peer selection as this could have lead to unpleasant experiences for a simple person participating in the network. lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some minor sync placement and clock skew issues. It also prepares user scoped node types and excludes them from the default sync placement behavior
Summary