Skip to content

Harden metadata sync placement and clock skew handling#299

Merged
St4NNi merged 5 commits into
mainfrom
fix/selector-clock
Jun 30, 2026
Merged

Harden metadata sync placement and clock skew handling#299
St4NNi merged 5 commits into
mainfrom
fix/selector-clock

Conversation

@St4NNi

@St4NNi St4NNi commented Jun 30, 2026

Copy link
Copy Markdown
Member

Fix some minor sync placement and clock skew issues. It also prepares user scoped node types and excludes them from the default sync placement behavior

Summary

  • Rebase selector-clock work onto current main without portal-serving changes.
  • Make sync peer selection independent of the local node identity.
  • Exclude user-device realm nodes from sync placement candidates and expose the node kind in info/admin config handling.
  • Reject inbound metadata events stamped beyond MAX_CLOCK_SKEW_SECS to avoid permanent last-writer-wins conflicts.

@das-Abroxas das-Abroxas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have clock-skew protection to prevent (malicious) last-writer-wins metadata event conflicts. Also good, that User nodes are now exempt from sync peer selection as this could have lead to unpleasant experiences for a simple person participating in the network. lgtm.

@St4NNi St4NNi merged commit a37d617 into main Jun 30, 2026
6 checks passed
@St4NNi St4NNi deleted the fix/selector-clock branch June 30, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants