Feat/group membership functionality#300
Merged
Merged
Conversation
das-Abroxas
previously approved these changes
Jul 1, 2026
das-Abroxas
left a comment
Contributor
There was a problem hiding this comment.
Left two minor comments but these are not important enough to withhold approval. Of course, you're still welcome to address these points.
das-Abroxas
approved these changes
Jul 1, 2026
das-Abroxas
left a comment
Contributor
There was a problem hiding this comment.
Thank you for addressing and resolving even these minor issues 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing group membership management flow for the API and portal member picker: users can be searched, invited to groups, removed from roles/groups, leave groups, and group roles can be managed safely.
Changes
GET /groups/{id}/membersto list group members and assigned roles, restricted to existing group members.POST /groups/{id}/membersto add users to a group, defaulting to the groupuserrole when no role ids are provided.DELETE /groups/{id}/members/{user_id}to remove a user from all group roles or from a specific role viarole_id.POST /groups/{id}/leavefor self-service group leave.409 Conflictwhen the operation would remove the final group admin.POST /groups/{id}/rolesto create custom group roles.DELETE /groups/{id}/roles/{role_id}to delete non-admin group roles.adminrole from deletion and maps the case to409 Conflict.GET /users/searchfor member-picker user search with same-realm auth, minimum query length, name/email matching, result limiting, and pagination.RemoveUserFromGroupOperation,RemoveGroupRoleOperation, andSearchUsersOperationin the operations layer.assigned_usersfrom open group info responses for non-members while keeping assignments visible to group members.aruna/tests/groups.rsand operation-level tests for the new operations.Related Issues