Normalize Kotlin when exits across nested control flow - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whenexits from nested conditional and try paths without consuming breaks owned by nested loopsThe two commits are ordered as one normalization pipeline: terminal exits first, then guarded and partial exits. Each commit independently passes formatting, the full library suite, and the end-to-end expected-output target.
Validation
cargo fmt --all -- --checkcargo check --workspacecargo test -p dexdec --lib(475 passed)dexdecintegration targets passednode --test scripts/version.test.mjsnpm ci && npm run buildBaseline comparisons
Review notes
The implementation distinguishes exits owned by the current
whenfrom breaks and continues owned by nested or enclosing loops. Partial exits are lowered only when the transformed statement preserves the original completion behavior.