fonts: add (Heavy) Ballot X to fallback font#2634
Open
arichardson wants to merge 5 commits intoasciidoctor:mainfrom
Open
fonts: add (Heavy) Ballot X to fallback font#2634arichardson wants to merge 5 commits intoasciidoctor:mainfrom
arichardson wants to merge 5 commits intoasciidoctor:mainfrom
Conversation
The script isn't too verbose and this makes it easier to debug
When the user id is mapped, it is no longer possible to read /home/fontforge since that could be owned by another user. Do the same as podman instead
The old URL is no longer accessible, download it from the newer github repo instead.
In preparation for adding more glyphs to the fallback fonts.
arichardson
added a commit
to arichardson/docs-resources
that referenced
this pull request
Feb 16, 2026
This ensures that the u000a glyph is included. Using the current version directly triggers another missing glyph warning which I fixed by generating a new font version that has the heavy ballot box X character. Update the existing font to use the new one from the asciidoctor-pdf pull request asciidoctor/asciidoctor-pdf#2634. Fixes: riscv#187
arichardson
added a commit
to arichardson/docs-resources
that referenced
this pull request
Feb 16, 2026
This ensures that the u000a glyph is included. Using the current version directly triggers another missing glyph warning which I fixed by generating a new font version that has the heavy ballot box X character. Update the existing font to use the new one from the asciidoctor-pdf pull request asciidoctor/asciidoctor-pdf#2634. Fixes: riscv#187 Signed-off-by: Alex Richardson <alexrichardson@google.com>
arichardson
added a commit
to arichardson/docs-resources
that referenced
this pull request
Feb 16, 2026
This ensures that the u000a glyph is included. Using the current version directly triggers another missing glyph warning which I fixed by generating a new font version that has the heavy ballot box X character. Update the existing font to use the new one from the asciidoctor-pdf pull request asciidoctor/asciidoctor-pdf#2634. Fixes: riscv#187 Signed-off-by: Alex Richardson <alexrichardson@google.com>
Member
|
Can we decide between heavy ballot X and heavy multiplication X? It just doesn't seem to me that we need both of them. I agree that having at least one would be an important complement to the checkbox. |
Author
Sounds good, I will drop the multiplication. |
arichardson
force-pushed
the
add-checkmarks-to-fallback
branch
from
d7109ee to
f6c3a6d
Compare
arichardson
changed the title
Author
|
Updated. I noticed that I also need 0x26AB (Medium Black Circle), can I include that in this pull request or should I submit a follow up? |
The fallback font already includes \u2713 (CHECK MARK) and \u2714 (HEAVY CHECK MARK), extend this to include (HEAVY) BALLOT X as that is a common character. For example, \u2718 (Heavy Ballot X) is used by the RISC-V specification documents.
arichardson
force-pushed
the
add-checkmarks-to-fallback
branch
from
f6c3a6d to
251a4ba
Compare
Author
|
Ping |
Member
|
I'm busy with other projects at the moment. I will come back to this when that work is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback font already includes \u2713 (CHECK MARK) and \u2714
(HEAVY CHECK MARK), extend this to include (HEAVY) BALLOT X as that is
a common character. For example, \u2718 (Heavy Ballot X) is used by
the RISC-V specification documents.