80 test driver app chat camera support - #163
Open
dimonco wants to merge 54 commits into
Open
Conversation
merge master into 80
…m/asepart/amosss182 into 80_testDriverAppChatCameraSupport
…m/asepart/amosss182 into 80_testDriverAppChatCameraSupport
It's needed in order for the Camera component to work
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 75.42% 75.42%
=======================================
Files 7 7
Lines 1078 1078
Branches 251 251
=======================================
Hits 813 813
Misses 93 93
Partials 172 172Continue to review full report at Codecov.
|
Contributor
|
before you merge, please test on IOS if everything builds properly |
Member
|
without npm start and expo we can't show ios support on the demo day, since apk can't be installed on ios. |
Contributor
Author
|
It is possible to run react-native run-ios, but I cannot test this because I don't have an iOS env |
|
Cannot be merged into master because it breaks iOS/Expo build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.