Extra sensors - #60
Closed
chribba021 wants to merge 5 commits into
Closed
Conversation
chribba021
marked this pull request as ready for review
November 10, 2024 00:10
|
Cool that you improved mine and Valentin's code from #57, but some mention/credit would have been nice. EDIT: Since you closed this PR for some reason, I've added your improvements back into the PR, with credits. |
Author
|
Author
|
Hi!, No idea what happened, I also had no intention to steal any credit for
what you guys started. I would rather prefer to maybe do pulls on your
pulls? I'm really new to github so don't understand the best practices and
how the correct way is to work on "open source" byt eager to learn.
I see that I may have closed my commit by mistake,
Should I open it or should I do updates in one of your merges instead?
Any pointing in the correct way of doing things is appreciated :)
/Christian
…On Wed, Nov 13, 2024 at 12:27 AM NewsGuyTor ***@***.***> wrote:
You know that you can edit stuff, right? ;)
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC64HNLQW4MVUDMST2KZEN32AKFHPAVCNFSM6AAAAABRPRTCICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRHAZTKNJUHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added extra sensor entities for the current room temperature for use in cards or helpers.
Will also add humidity and floor temperatur if the Thermostat reports it.
Device now includes sensors:
Creates separate senor entities for temp,
(wanted it to make a helper with arimetic median for average indoor temp in the house)
Added extra debug logging, will list termostats and name on
[custom_components.uponor] Unloading setup entry:
e.g: data: {'host': '192.168.1.131', 'name': 'Uponor', 'c1_t1': 'Guest Room', 'c1_t2': 'Office',
DEBUG (MainThread) [custom_components.uponor] Unload status for Uponor platforms: True
DEBUG (MainThread) [custom_components.uponor.sensor] Adding sensors for Guest Room (thermostat ID: C1_T1)
DEBUG (MainThread) [custom_components.uponor.sensor] Total amount of sensors added: xx