Any-style dynamic downcasts - #707
Open
SNoAnd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two related structures: a trait mechanism representing a collection of distinct types, distinguished by an abstract
type_id; and an implementation as a fixed-size array of bytes with thetype_idtracked as a ghost variable (GhostTaggedArray).This allows us to:
MetaSlotwith an object that is binary-equivalent, as opposed toMetaSlotStorage, which carries an extra tag to distinguish its contentsdyn AnyFrameMetasoundlywrite_metapreserves the proper relationship between the metadata type as seen by the compiler, the type's bit-pattern, andvtable_ptrAn alternative approach would be to modify Verus to expose its internal
typeIds to the verification. Then we could do away with the complex trait system, but keep the underling ghost-tagged-array representation.