res_stasis/resource_bridges: Split bridge playback control and wrapper cleanup#1876
Open
pekkaar wants to merge 1 commit intoasterisk:masterfrom
Open
res_stasis/resource_bridges: Split bridge playback control and wrapper cleanup#1876pekkaar wants to merge 1 commit intoasterisk:masterfrom
pekkaar wants to merge 1 commit intoasterisk:masterfrom
Conversation
…r cleanup Modified the bridge playback teardown so the worker thread removes only the playback control, while the after-bridge callback removes the playback wrapper once the announcer has actually left the bridge. This avoids a stale window where a new playback request could create a replacement announcer before the old announcer had fully exited the holding bridge. Also replaced the flexible trailing bridge_id storage in the shared worker thread data with an optional bridge_id pointer, since recording paths use the same structure without a bridge id. Fixes: asterisk#1861
Contributor
Author
|
cherry-pick-to: 23 |
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check completed successfully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the bridge playback teardown so the worker thread removes only the
playback control, while the after-bridge callback removes the playback
wrapper once the announcer has actually left the bridge.
This avoids a stale window where a new playback request could create a
replacement announcer before the old announcer had fully exited the holding
bridge.
Also replaced the flexible trailing bridge_id storage in the shared worker
thread data with an optional bridge_id pointer, since recording paths use the
same structure without a bridge id.
Fixes: #1861