Check direct minimum versions in CI - #60
Merged
Merged
Conversation
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
charliermarsh
force-pushed
the
charlie/fix-minimal-versions
branch
from
June 28, 2026 15:47
e4a4f05 to
5ebb5a4
Compare
charliermarsh
changed the title
charliermarsh
marked this pull request as ready for review
June 28, 2026 15:56
konstin
pushed a commit
that referenced
this pull request
Jun 28, 2026
The minimal-versions job currently resolves every transitive dependency to its lowest allowed version, which [Cargo does not recommend](https://doc.rust-lang.org/cargo/reference/unstable.html#minimal-versions). This selected `rustix 0.37.0` through a development dependency and caused the job to fail on current nightly, even though PubGrub's own dependency bounds were valid. Switch to direct minimum versions so we validate the lower bounds we declare while resolving transitive dependencies normally. Use nightly only to generate that lockfile, then build and test it with stable Rust. Align the root crate's Serde lower bound with `astral-version-ranges` so the workspace has one consistent direct minimum. The resulting direct-minimum dependency graph builds and passes all workspace tests with all features; the normal locked graph does as well.
konstin
reviewed
Jun 28, 2026
| - run: cargo build --workspace | ||
|
|
||
| - run: cargo +nightly test --all-features --workspace | ||
| - run: cargo test --all-features --workspace |
Member
There was a problem hiding this comment.
We added half of that fix in pubgrub-rs#426 previously, I now rebased main onto upstream dev which makes this part disappear.
konstin
added a commit
that referenced
this pull request
Jun 28, 2026
The minimal-versions job currently resolves every transitive dependency to its lowest allowed version, which [Cargo does not recommend](https://doc.rust-lang.org/cargo/reference/unstable.html#minimal-versions). This selected `rustix 0.37.0` through a development dependency and caused the job to fail on current nightly, even though PubGrub's own dependency bounds were valid. Switch to direct minimum versions so we validate the lower bounds we declare while resolving transitive dependencies normally. Use nightly only to generate that lockfile, then build and test it with stable Rust. Align the root crate's Serde lower bound with `astral-version-ranges` so the workspace has one consistent direct minimum. The resulting direct-minimum dependency graph builds and passes all workspace tests with all features; the normal locked graph does as well. Co-authored-by: Charlie Marsh <crmarsh416@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimal-versions job currently resolves every transitive dependency to its lowest allowed version, which Cargo does not recommend. This selected
rustix 0.37.0through a development dependency and caused the job to fail on current nightly, even though PubGrub's own dependency bounds were valid.Switch to direct minimum versions so we validate the lower bounds we declare while resolving transitive dependencies normally. Use nightly only to generate that lockfile, then build and test it with stable Rust. Align the root crate's Serde lower bound with
astral-version-rangesso the workspace has one consistent direct minimum.The resulting direct-minimum dependency graph builds and passes all workspace tests with all features; the normal locked graph does as well.