[ty] Remove per-scope tracking of reachability#24457
Merged
AlexWaygood merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 41 | 0 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
AlexWaygood
force-pushed
the
alex/scope-memory
branch
2 times, most recently
from
32eadbc to
ce75456
Compare
AlexWaygood
force-pushed
the
alex/scope-memory
branch
from
ce75456 to
cb94ae0
Compare
AlexWaygood
changed the title
Scope
AlexWaygood
requested review from
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
sharkdp
approved these changes
Apr 8, 2026
Contributor
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Awesome, thank you.
Not sure what I did wrong when I tried to do the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same as #24472, but for the
reachabilityfield onScope. We no longer need to track reachability of scopes; we can use the more generalisedis_range_reachablemethod onSemanticIndexand iterate up through all parent scopes.Performance is in the noise here -- maybe a 1% slowdown on a few benchmarks, but a 1% speedup on one microbenchmark.
Test Plan
Existing tests all pass