Skip to content

[ty] Detect final methods through intersections.#25749

Draft
lerebear wants to merge 1 commit into
lerebear/push-tpzpnlynlywmfrom
lerebear/push-wnpokoynuoqu
Draft

[ty] Detect final methods through intersections.#25749
lerebear wants to merge 1 commit into
lerebear/push-tpzpnlynlywmfrom
lerebear/push-wnpokoynuoqu

Conversation

@lerebear

@lerebear lerebear commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Test Plan

@astral-sh-bot astral-sh-bot Bot added the ty Multi-file analysis & type inference label Jun 8, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.92%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 21 regressed benchmarks
✅ 46 untouched benchmarks
⏩ 60 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation hydra-zen 1.2 s 3.1 s -60.5%
WallTime pydantic 10.1 s 15.4 s -34.34%
WallTime multithreaded 1.6 s 2 s -19.59%
WallTime altair 5.6 s 6.9 s -19.2%
WallTime freqtrade 9.1 s 10.4 s -12.85%
Simulation anyio 1.2 s 1.3 s -8.74%
Simulation ty_check_file[incremental] 7.1 ms 7.8 ms -8.44%
Simulation ty_micro[pydantic_core_schema_dict] 112.7 ms 121.6 ms -7.3%
Simulation attrs 549.7 ms 591.5 ms -7.06%
WallTime pandas 70.8 s 76 s -6.75%
WallTime tanjun 3.2 s 3.4 s -6.58%
Memory ty_micro[typeis_narrowing] 18.7 MB 20 MB -6.26%
Memory ty_check_file[incremental] 136.9 KB 145.6 KB -5.99%
Simulation ty_check_file[cold] 148.9 ms 157.9 ms -5.69%
Simulation ty_micro[typevar_mapping_accumulation] 994 ms 1,053 ms -5.6%
WallTime sympy 81.2 s 85.9 s -5.49%
Simulation ty_micro[recursive_typed_dict_union_contextual_inference] 92.5 ms 97.2 ms -4.83%
Memory ty_micro[vararg_parameter_type_accumulation] 10.9 MB 11.4 MB -4.44%
Memory anyio 64.3 MB 67.1 MB -4.14%
Memory ty_micro[pandas_tdd] 34.5 MB 36 MB -4.05%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression with the CodSpeed MCP and your agent.


Comparing lerebear/push-wnpokoynuoqu (5428fde) with lerebear/push-tpzpnlynlywm (080558b)

Open in CodSpeed

Footnotes

  1. 60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant