[ty] Compact retained member lookup keys#25776
Open
charliermarsh wants to merge 1 commit into
Open
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.23%. The percentage of expected errors that received a diagnostic held steady at 87.42%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
Member
Author
|
This seems plausibly good to me given that it also has a positive effect on the multi-threaded benchmark. |
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
carljm
approved these changes
Jun 9, 2026
carljm
left a comment
carljm
left a comment
Contributor
There was a problem hiding this comment.
This looks fine. It does seem like it has a small but definite memory improvement. Not convinced there's a meaningful perf impact, from looking at CodSpeed and ecosystem timings. I would say for me this seems right on the bubble of "worth it", but I don't object to landing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class_member_with_policyandmember_lookup_with_policy_innercurrently retain the full Salsa argument set for every lookup, even though almost all calls use the default policy, do not need a separate receiver, and many class-member lookups request__get__.This change routes those common cases through narrower tracked queries. Default class lookups no longer retain a policy,
__get__lookups no longer retain a name or policy, and default instance lookups no longer retain a policy or absent receiver. Non-default policies and explicit receivers continue through dedicated tracked queries, and all paths share the existing lookup implementation and cycle handling.