Use ICF for macOS release builds#25780
Draft
zaniebot wants to merge 1 commit into
Draft
Conversation
zaniebot
force-pushed
the
zb/macos-icf-release-builds
branch
from
1dc7822 to
8e38a4b
Compare
zaniebot
force-pushed
the
zb/macos-icf-release-builds
branch
from
8e38a4b to
e0eb28d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Rust's bundled Mach-O LLD with
--icf=safefor macOS release builds.The workflow scopes the linker flags to the macOS wheel builds.
Related uv change: astral-sh/uv#19615
CI Results
Build binaries run: https://github.com/astral-sh/ruff/actions/runs/27213897587
Measured with a same-commit A/B release build on a Namespace macOS ARM machine, using
maturin 1.13.3and Rust1.96. The x86_64 row was cross-built from the ARM machine.macos-x86_64macos-aarch64The binary size measures installed/on-disk impact; the wheel size measures network/download size.