Add fault icons for org.knx (KNX smoke sensor capabilities) - #410
Closed
LaurensVanAcker wants to merge 1 commit into
Closed
Add fault icons for org.knx (KNX smoke sensor capabilities)#410LaurensVanAcker wants to merge 1 commit into
LaurensVanAcker wants to merge 1 commit into
Conversation
For PR athombv/org.knx#85, which extends the KNX smoke sensor with extra fault and signalling channels exposed by Gira smoke alarms. Adds 4 monochrome 64x64 SVGs for the new capabilities: - knx_failure_smoke (smoke sensor failure) - knx_failure_temperature (temperature sensor failure) - knx_failure_230v (230V power failure) - knx_acknowledge_fault (reset/acknowledge button) The alarm_signal (siren) capability reuses the existing "homey capability Icons/alarm_siren.svg" — no new file needed.
Author
|
Closing — I misread the icon workflow. The icons belong inside the app at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App ID:
org.knxThese icons are needed for athombv/org.knx#85, which extends the KNX smoke sensor with the full set of fault and signalling channels exposed by Gira smoke alarm objects.
Adds 4 monochrome 64x64 SVGs under
org.knx/:knx_failure_smoke.svg— smoke sensor failureknx_failure_temperature.svg— temperature sensor failureknx_failure_230v.svg— 230V power failureknx_acknowledge_fault.svg— reset/acknowledge buttonThe 5th new capability in that PR (
knx_alarm_signal, the siren control) reuses the existinghomey capability Icons/alarm_siren.svg— no new file needed.These are first-pass drafts in the existing flat monochrome style — happy to iterate if the design team prefers a different direction.
cc @wlcrs