Use Array.isArray instead of instanceof Array for assertion - #1841
Merged
liamqma merged 1 commit intoJul 7, 2025
Conversation
marcins
requested review from
JakeLane,
danieldelcore,
dddlr,
kylorhall-atlassian,
liamqma and
pancaspe87
as code owners
July 7, 2025 03:41
🦋 Changeset detectedLatest commit: f3b87ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
liamqma
approved these changes
Jul 7, 2025
JakeLane
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change?
Changing
assert(rules instanceof Array)toassert(Array.isArray(rules)).Why are we making this change?
The previous check can fail in an environment where the array was created in a different "context" (i.e. workers)
PR checklist
Don't delete me!
I have...
website/