db: create migration for figma file webhooks - #259
Merged
Conversation
Isaiah-Turner
requested review from
Roystbeef,
akostevich-atlassian and
knguyen-figma
August 1, 2025 22:53
Isaiah-Turner
marked this pull request as ready for review
August 1, 2025 22:53
| @@map("jira_figma_team") | ||
| } | ||
|
|
||
| model FigmaFileWebhook { |
Collaborator
There was a problem hiding this comment.
suggestion (non-blocking): We could also consider storing webhook subscriptions in different tables (one per a webhook type), so they can be scaled and evolved separately.
However, if we think that both FILE_UPDATE and DEV_MODE_STATUS_UPDATE belong to the same family of events (File-based events) and managed in the same way, the currently solution is perfectly fine!
Collaborator
Author
There was a problem hiding this comment.
Good point! IMO these events are similar enough that we probably can treat and manage them in the same table
akostevich-atlassian
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Figma file webhooks. It adds a new table to keep track of our file webhooks, similar to how
FigmaTeamkeeps track of our team based webhooks.I used the command
npx prisma migrate dev --name add_file_webhook_tableto generate the migration SQL after making manual changes toschema.prismaTesting