Skip to content

db: create migration for figma file webhooks - #259

Merged
Isaiah-Turner merged 1 commit into
mainfrom
isaiah/file-webhooks-db-migration
Aug 13, 2025
Merged

db: create migration for figma file webhooks#259
Isaiah-Turner merged 1 commit into
mainfrom
isaiah/file-webhooks-db-migration

Conversation

@Isaiah-Turner

@Isaiah-Turner Isaiah-Turner commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

This PR adds support for Figma file webhooks. It adds a new table to keep track of our file webhooks, similar to how FigmaTeam keeps track of our team based webhooks.

I used the command npx prisma migrate dev --name add_file_webhook_table to generate the migration SQL after making manual changes to schema.prisma

Testing

@Isaiah-Turner Isaiah-Turner changed the title [NONE] create migration for figma file webhooks db: create migration for figma file webhooks Aug 1, 2025
@Isaiah-Turner
Isaiah-Turner marked this pull request as ready for review August 1, 2025 22:53
Comment thread prisma/schema.prisma
@@map("jira_figma_team")
}

model FigmaFileWebhook {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): We could also consider storing webhook subscriptions in different tables (one per a webhook type), so they can be scaled and evolved separately.

However, if we think that both FILE_UPDATE and DEV_MODE_STATUS_UPDATE belong to the same family of events (File-based events) and managed in the same way, the currently solution is perfectly fine!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! IMO these events are similar enough that we probably can treat and manage them in the same table

@Isaiah-Turner
Isaiah-Turner merged commit 70b86d7 into main Aug 13, 2025
2 checks passed
@Isaiah-Turner
Isaiah-Turner deleted the isaiah/file-webhooks-db-migration branch August 13, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants