don't expand abstract types to object fragments where possible - #732
Merged
Conversation
gnawf
reviewed
Jul 13, 2026
| ?: return null | ||
|
|
||
| // Do nothing for fields with instructions (rename/hydration/stub/…) | ||
| val hasFieldInstructions = runCatching { |
Collaborator
There was a problem hiding this comment.
Can we rewrite this to avoid expecting an exception and using runCatching to catch it.
| val isTypename = overallField.fieldName == TypeNameMetaFieldDef.name | ||
|
|
||
| // getFieldDefinitions can throw while planning a hydration backing query; any failure => not a candidate. | ||
| val parentOutputTypes = runCatching { |
Collaborator
There was a problem hiding this comment.
Same as before, shouldn't rely on try catch here. If the type doesn't exist in engineSchema then it should be handled without throwing.
| val exposedOverallImplNames: Set<String> | ||
| val parentAbstractTypeName: String | ||
| when (val parentType = parentOutputTypes.singleOrNull()) { | ||
| is GraphQLInterfaceType -> { |
Collaborator
There was a problem hiding this comment.
In theory if there are multiple output interfaces and the field exists on all of them that works too.
gnawf
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure you consider the following: