Skip to content

bugfix: don't widen the type conditions in the NadelServiceTypeFilter…#741

Open
temaEmelyan wants to merge 1 commit into
masterfrom
dont-widen-type-conditions
Open

bugfix: don't widen the type conditions in the NadelServiceTypeFilter…#741
temaEmelyan wants to merge 1 commit into
masterfrom
dont-widen-type-conditions

Conversation

@temaEmelyan

Copy link
Copy Markdown
Member

…Transform

Please make sure you consider the following:

  • Add tests that use __typename in queries
  • Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • Do we need to add integration tests for this change in the graphql gateway?
  • Do we need a pollinator check for this?

@temaEmelyan temaEmelyan self-assigned this Jul 24, 2026
@temaEmelyan
temaEmelyan requested a review from gnawf July 24, 2026 04:03
@github-actions

Copy link
Copy Markdown

Test Results

  663 files  +  663    663 suites  +663   1m 9s ⏱️ + 1m 9s
2 227 tests +2 227  1 663 ✅ +1 663  564 💤 +564  0 ❌ ±0 
2 235 runs  +2 235  1 671 ✅ +1 671  564 💤 +564  0 ❌ ±0 

Results for commit 78faa13. ± Comparison against base commit 81a0db2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant