Fix useEffect syntax error in conditional dragging docs#237
Open
drtootsie wants to merge 1 commit intoatlassian:mainfrom
Open
Fix useEffect syntax error in conditional dragging docs#237drtootsie wants to merge 1 commit intoatlassian:mainfrom
drtootsie wants to merge 1 commit intoatlassian:mainfrom
Conversation
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
Addresses atlassian#224 Fixed incorrect useEffect syntax in the conditional dragging documentation. Changed: useEffect({ To: useEffect(() => { useEffect expects a callback function as its first argument, not an object.
drtootsie
force-pushed
the
fix-useffect-docs-typo
branch
from
42b9988 to
d1833dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #224
Fixed incorrect
useEffectsyntax in the conditional dragging documentation example.Change
Why
useEffectexpects a callback function as its first argument, not an object. This was causing confusion for developers copying the example code.Testing
Upgrade to Rovo Dev Standard to continue using code review.