Skip to content

Bugfix value spec variables - #118

Merged
LiamHobby merged 3 commits into
mainfrom
bugfix-value-spec-variables
Jul 11, 2025
Merged

Bugfix value spec variables#118
LiamHobby merged 3 commits into
mainfrom
bugfix-value-spec-variables

Conversation

@LiamHobby

Copy link
Copy Markdown
Collaborator

Fixed a bug where the presence of variables with VLM in the value_spec table would prevent variables of the same name being populated in the value_spec table from different datasets. The anti-join was performed on variable only - changed to c(variable, dataset).

@codecov

codecov Bot commented Jul 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (d4b3530) to head (eff75ce).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
R/spec_builder.R 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   85.64%   85.44%   -0.20%     
==========================================
  Files           8        8              
  Lines        1170     1175       +5     
==========================================
+ Hits         1002     1004       +2     
- Misses        168      171       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LiamHobby
LiamHobby merged commit 0c13a88 into main Jul 11, 2025
7 of 9 checks passed
@LiamHobby
LiamHobby deleted the bugfix-value-spec-variables branch September 30, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant