Skip to content

Closes #122 Closes #120 - #126

Merged
LiamHobby merged 6 commits into
0.3.0from
Closes_122
Dec 16, 2025
Merged

Closes #122 Closes #120#126
LiamHobby merged 6 commits into
0.3.0from
Closes_122

Conversation

@sadchla-codes

Copy link
Copy Markdown
Collaborator

quiet argument in spec_to_metacore() and select_dataset functions will suppress optional messages, notes and warnings when it is set to TRUE.

…elect_dataset` functions is truly quiet
@codecov

codecov Bot commented Nov 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.38095% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.86%. Comparing base (8e2a2f0) to head (6b30180).
⚠️ Report is 15 commits behind head on 0.3.0.

Files with missing lines Patch % Lines
R/spec_builder.R 85.71% 4 Missing ⚠️
R/metacore.R 93.61% 3 Missing ⚠️
R/xml_builders.R 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.0     #126      +/-   ##
==========================================
+ Coverage   85.85%   85.86%   +0.01%     
==========================================
  Files           8        9       +1     
  Lines        1223     1224       +1     
==========================================
+ Hits         1050     1051       +1     
  Misses        173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bms63

bms63 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Hey @LiamHobby can you review this please

@LiamHobby LiamHobby left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but I think there are a few things that could be streamlined and one place where I think the call to suppressMessages was missed (when metacore() is called directly).
Thanks

Comment thread R/metacore.R Outdated
Comment thread R/metacore.R Outdated
@LiamHobby
LiamHobby changed the base branch from main to 0.3.0 December 9, 2025 12:40
sadchla-codes and others added 2 commits December 12, 2025 00:49
…etacore()`, `select_dataset()`, and `define_to_metacore()` functions to incorporate the `quiet_if_true()` and added tests
@sadchla-codes

Copy link
Copy Markdown
Collaborator Author

Hi @LiamHobby I have added the quiet_if_true() in the util.R program and refactor spec_to_metacore(), define_to_metacore(), select_dataset() and metacore() functions to used the quiet_if_true(). I also added some tests.

@LiamHobby LiamHobby left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against example code in original issue (#120) and reviewed new test cases.

@LiamHobby
LiamHobby merged commit 4d47c1f into 0.3.0 Dec 16, 2025
17 of 19 checks passed
@LiamHobby
LiamHobby deleted the Closes_122 branch January 26, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend function of quiet option to suppress optionally messages, warnings, or both Change quiet to suppress messages instead of warnings

3 participants