Closes #80 Align core attribute documentation with ADaM IG 1.3 and SDTM standards - #127
Merged
bms63 merged 5 commits intoDec 9, 2025
Conversation
Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Readme to clarify core values
Align core attribute documentation with ADaM IG 1.3 and SDTM standards
Nov 24, 2025
Collaborator
|
I asked copilot to do this - trying to figure out how to prompt things better!! seems like it got all the relevant points just from the issue!! |
bms63
marked this pull request as ready for review
December 1, 2025 02:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 80-documentation-core-in-readme #127 +/- ##
================================================================
Coverage 85.44% 85.44%
================================================================
Files 8 8
Lines 1175 1175
================================================================
Hits 1004 1004
Misses 171 171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpiraux
reviewed
Dec 2, 2025
cpiraux
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this update! I have one small comment; the rest looks good to me!
bms63
reviewed
Dec 5, 2025
bms63
reviewed
Dec 5, 2025
Collaborator
|
@LiamHobby and @cpiraux all good? |
LiamHobby
approved these changes
Dec 9, 2025
LiamHobby
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks Ben!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation incorrectly listed "Expected" and "Conditionally Expected" as valid ADaM core values. Per ADaM IG 1.3 pg 14, ADaM only uses: Required, Conditionally Required, and Permissible.
Changes
coreattribute description inds_varstable to specify:Scope
Validation logic in
R/validators.Runchanged to avoid breaking existing metadata that may use the broader set of values.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.