Update keep to mandatory in ds_vars table - #128
Merged
Merged
Conversation
Increment version number to 0.3.0
Merge branch '81-mandatory' of github.com:atorus-research/metacore into 81-mandatory # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.3.0 #128 +/- ##
==========================================
+ Coverage 85.50% 85.51% +0.01%
==========================================
Files 8 9 +1
Lines 1173 1174 +1
==========================================
+ Hits 1003 1004 +1
Misses 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@cpiraux I have implemented the deprecation message on package load in order to remove the duplicated variable as discussed in the stand-up meeting. If you could review the updated wording in the documentation that would be great. Thanks! |
cpiraux
reviewed
Dec 10, 2025
cpiraux
left a comment
cpiraux
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Just added a small comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81.
Updated old variable
keeptomandatoryto better reflect the wording in CDISC Define-XML. Changed references throughout the package and in associated documentation.No functions in {metatools} leverage the old
keepvariable so there should be limited impact on dependent packages.